Re: [PATCH v3] xen-netfront: Improve error handling during initialization

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] xen-netfront: Improve error handling during initialization
Date	2017-02-09 23:00 +0100
Message-ID	<t94UV-33U-5@gated-at.bofh.it> (permalink)
References	<t8y8G-7Ir-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Ross Lagerwall <ross.lagerwall@citrix.com>
Date: Wed, 8 Feb 2017 10:57:37 +0000

> This fixes a crash when running out of grant refs when creating many
> queues across many netdevs.
> 
> * If creating queues fails (i.e. there are no grant refs available),
> call xenbus_dev_fatal() to ensure that the xenbus device is set to the
> closed state.
> * If no queues are created, don't call xennet_disconnect_backend as
> netdev->real_num_tx_queues will not have been set correctly.
> * If setup_netfront() fails, ensure that all the queues created are
> cleaned up, not just those that have been set up.
> * If any queues were set up and an error occurs, call
> xennet_destroy_queues() to clean up the napi context.
> * If any fatal error occurs, unregister and destroy the netdev to avoid
> leaving around a half setup network device.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] xen-netfront: Improve error handling during initialization Ross Lagerwall <ross.lagerwall@citrix.com> - 2017-02-08 12:00 +0100
  Re: [PATCH v3] xen-netfront: Improve error handling during  initialization Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-08 15:40 +0100
  Re: [PATCH v3] xen-netfront: Improve error handling during  initialization David Miller <davem@davemloft.net> - 2017-02-09 23:00 +0100

csiph-web