Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1577978

Re: [PATCH v2] eeprom/at24: use device_property_*() functions instead of of_get_property()

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] eeprom/at24: use device_property_*() functions instead of of_get_property()
Date 2017-02-09 22:40 +0100
Message-ID <t94BA-2X8-17@gated-at.bofh.it> (permalink)
References <t8Zsd-8j1-1@gated-at.bofh.it> <t93Fw-2mP-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 9, 2017 at 10:35 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Ben,
>
> [auto build test ERROR on char-misc/char-misc-testing]
> [also build test ERROR on v4.10-rc7 next-20170209]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Optimistic way of thinking: kbuild bot was fast enough.
Pessimistic: it wasn't too slow enough.

P.S. I think it against older version of the patch, thus, we may
safely ignore this.

>
> url:    https://github.com/0day-ci/linux/commits/Ben-Gardner/eeprom-at24-use-device_property_-functions-instead-of-of_get_property/20170210-025938
> config: x86_64-rhel (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>    drivers/misc/eeprom/at24.c: In function 'at24_get_pdata':
>>> drivers/misc/eeprom/at24.c:580:7: error: 'chip' is a pointer; did you mean to use '->'?
>       chip.page_size = 1;
>           ^
>           ->
>
> vim +580 drivers/misc/eeprom/at24.c
>
>    574          } else {
>    575                  /*
>    576                   * This is slow, but we can't know all eeproms, so we better
>    577                   * play safe. Specifying custom eeprom-types via platform_data
>    578                   * is recommended anyhow.
>    579                   */
>  > 580                  chip.page_size = 1;
>    581          }
>    582  }
>    583
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] eeprom/at24: use device_property_*() functions instead of of_get_property() Ben Gardner <gardner.ben@gmail.com> - 2017-02-08 23:50 +0100
  Re: [PATCH] eeprom/at24: use device_property_*() functions instead of of_get_property() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-09 01:10 +0100
    Re: [PATCH] eeprom/at24: use device_property_*() functions instead of of_get_property() Ben Gardner <gardner.ben@gmail.com> - 2017-02-09 16:40 +0100
  [PATCH v2] eeprom/at24: use device_property_*() functions instead of of_get_property() Ben Gardner <gardner.ben@gmail.com> - 2017-02-09 17:10 +0100
    Re: [PATCH v2] eeprom/at24: use device_property_*() functions instead  of of_get_property() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-09 17:30 +0100
      Re: [PATCH v2] eeprom/at24: use device_property_*() functions instead  of of_get_property() Ben Gardner <gardner.ben@gmail.com> - 2017-02-09 19:50 +0100
    Re: [PATCH v2] eeprom/at24: use device_property_*() functions instead  of of_get_property() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-09 22:40 +0100
    Re: [PATCH v2] eeprom/at24: use device_property_*() functions  instead of of_get_property() kbuild test robot <lkp@intel.com> - 2017-02-10 01:00 +0100

csiph-web