Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577937
| From | Jacek Anaszewski <jacek.anaszewski@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC |
| Date | 2017-02-09 21:40 +0100 |
| Message-ID | <t93Fw-2mP-3@gated-at.bofh.it> (permalink) |
| References | <t8qb8-2BH-5@gated-at.bofh.it> <t8qb8-2BH-19@gated-at.bofh.it> <t8HF0-5pA-23@gated-at.bofh.it> <t8Y37-7ju-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/09/2017 03:23 PM, Pavel Machek wrote: > Hi! > >>> +/* >>> + * Register for MT6323_ISINK_CON0 to setup the >>> + * duty cycle of the blink >>> + */ >>> +#define MT6323_ISINK_CON0(i) (MT6323_ISINK0_CON0 + 0x8 * (i)) >>> +#define MT6323_ISINK_DIM_DUTY_MASK (0x1f << 8) >>> +#define MT6323_ISINK_DIM_DUTY(i) (((i) << 8) & \ >>> + MT6323_ISINK_DIM_DUTY_MASK) >>> + >>> +/* >>> + * Register to setup the period of the blink >>> + */ >> >> This fits in a single line, so can be wrapped with /* */ like : > > People do this to make blocks stand out, and to make it similar to other blocks > above. I believe this is ok. It generates unnecessary lines of code, but I'm not going to argue, let's leave it to the developer's taste. -- Best regards, Jacek Anaszewski
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] leds: add leds-mt6323 support on MT7623 SoC <sean.wang@mediatek.com> - 2017-02-08 03:30 +0100
[PATCH v2 2/4] Documentation: devicetree: Add LED subnode binding for MT6323 PMIC <sean.wang@mediatek.com> - 2017-02-08 03:30 +0100
Re: [PATCH v2 2/4] Documentation: devicetree: Add LED subnode binding for MT6323 PMIC Lee Jones <lee.jones@linaro.org> - 2017-02-08 13:30 +0100
[PATCH v2 3/4] leds: Add LED support for MT6323 PMIC <sean.wang@mediatek.com> - 2017-02-08 03:30 +0100
Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-02-08 22:10 +0100
Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC Sean Wang <sean.wang@mediatek.com> - 2017-02-09 07:20 +0100
Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC Pavel Machek <pavel@ucw.cz> - 2017-02-09 15:40 +0100
Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-02-09 21:40 +0100
[PATCH v2 4/4] mfd: mt6397: Add MT6323 LED support into MT6397 driver <sean.wang@mediatek.com> - 2017-02-08 03:30 +0100
Re: [PATCH v2 4/4] mfd: mt6397: Add MT6323 LED support into MT6397 driver Lee Jones <lee.jones@linaro.org> - 2017-02-08 13:30 +0100
csiph-web