Re: [RFC,v2 2/3] sched: set number of iterations to h_nr_running

From	Uladzislau Rezki <urezki@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC,v2 2/3] sched: set number of iterations to h_nr_running
Date	2017-02-09 20:10 +0100
Message-ID	<t92gq-1CS-17@gated-at.bofh.it> (permalink)
References	<t8wgy-6w4-11@gated-at.bofh.it> <t8wgy-6w4-9@gated-at.bofh.it> <t8X77-6JS-93@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 9, 2017 at 1:20 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Feb 08, 2017 at 09:43:28AM +0100, Uladzislau Rezki wrote:
>> From: Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>
>>
>> It is possible that busiest run queue has multiple RT tasks,
>> whereas no CFS tasks, that is why it is reasonable to use
>> h_nr_running instead, because a load balance only applies
>> for CFS related tasks.
>

>
> Sure, I suppose that makes sense, but then it would make even more sense
> to do a more thorough audit of the code and make sure all remaining
> rq::nr_running uses are correct.
>
Indeed. I did not want to touch othe places, due to my specific test case.
There are still a few raming places. I can prepare a new patch that covers
all of them if that is ok.

-- 
Uladzislau Rezki

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC,v2 2/3] sched: set number of iterations to h_nr_running Uladzislau Rezki <urezki@gmail.com> - 2017-02-08 10:00 +0100
  Re: [RFC,v2 2/3] sched: set number of iterations to h_nr_running Peter Zijlstra <peterz@infradead.org> - 2017-02-09 14:40 +0100
    Re: [RFC,v2 2/3] sched: set number of iterations to h_nr_running Uladzislau Rezki <urezki@gmail.com> - 2017-02-09 20:10 +0100

csiph-web