Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577772

Re: [PATCH] staging: greybus: uart: fix uninitialized newline.flow_control

Show all headers | View raw

On Thu, Feb 09, 2017 at 01:01:18PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently newline.flow_control is uninitialized, so it can contain
> any garbage from the stack.  I believe it should be initialized with
> GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS
> enabled.

Good catch. The CRTSCTS flag is actually honoured a bit further down in
the set_termios(), but there's a bug in that it assumes newline to have
been initialised with the current (old) values. It should
unconditionally set the flow_control field rather than manipulate bits
(we currently use one bit of this field).

Care to send a v2 fixing this up as suggested above?

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: greybus: uart: fix uninitialized newline.flow_control Colin King <colin.king@canonical.com> - 2017-02-09 14:10 +0100
  Re: [PATCH] staging: greybus: uart: fix uninitialized  newline.flow_control Johan Hovold <johan@kernel.org> - 2017-02-09 17:50 +0100

csiph-web