Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Vivek Gautam <vivek.gautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration
Date	Wed, 08 Feb 2017 13:20:02 +0100
Message-ID	<t8zo6-dB-11@gated-at.bofh.it> (permalink)
References	<t8zo6-dB-13@gated-at.bofh.it> <t8zo6-dB-15@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486555059; bh=S7cNdw9HPw40/jfVppsL3lchqTlAALBaoDq1r3Vgawo=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=gWEiXXxiVYWKUuPb29c6nnpGe+VwIzaCv/jK35citG7uDXgRoegCoZK5uusjVwhdZ M6bjihH/bFJdECOlsEo7nbUPEM8byUKuZ34lyoBSNOms8dDBx5O8O1ve8WwXKigIWS CsDjny0yB1MnI+0TutTwMmszpsKs+9sYz1zijRU4=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486555053; bh=S7cNdw9HPw40/jfVppsL3lchqTlAALBaoDq1r3Vgawo=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=Vxk6qppw/mDyAPv69XXx7dXmI6/QauG2IxzocAAb2HJS7LyEaCDsj+OkMHhY74Ksn Njn7IT1gXA5sDnM2s7GAHPT3PeIg7LWeqUGPA9uKN9uTRI6O6V5gVkE1Y3NNwNo0ED +V3o6ey2jRy3DVlMiPRjT3EGiuSKTXmM7jGmGXwA=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org D799960A80
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org
X-Gm-Message-State	AMke39khycSMZbMvLKUFO+ENpuwQytfz/mxLYHUc+l3lsZM1lLwb4va7IlMRqrgC4u/fcxs3KED+Q9QNJhubmg==
X-Received	by 10.55.105.131 with SMTP id e125mr21190706qkc.174.1486555051860; Wed, 08 Feb 2017 03:57:31 -0800 (PST)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAFp+6iEtFetHY6FEAYD2Ymjr+BKyVKjaum_F8v4e8wapnFcK8w@mail.gmail.com>
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Greg KH <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu>, Ulf Hansson <ulf.hansson@linaro.org>, broonie@kernel.org, sre@kernel.org, "robh+dt" <robh+dt@kernel.org>, shawnguo@kernel.org, rjw@rjwysocki.net, dbaryshkov@gmail.com, Heiko Stübner <heiko@sntech.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, p.zabel@pengutronix.de, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Linux USB Mailing List <linux-usb@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, s.hauer@pengutronix.de, mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com, festevam@gmail.com, oscar@naiandei.net, Stephen Boyd <stephen.boyd@linaro.org>, linux-pm@vger.kernel.org, stillcompiling@gmail.com, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, mka@chromium.org, vaibhav.hiremath@linaro.org, gary.bisson@boundarydevices.com, Hans Verkuil <hverkuil@xs4all.nl>, krzk@kernel.org, Sriram Dash <sriram.dash@nxp.com>, Mathias Nyman <mathias.nyman@linux.intel.com>
X-Original-Date	Wed, 8 Feb 2017 17:27:31 +0530
X-Original-Message-ID	<CAFp+6iEtFetHY6FEAYD2Ymjr+BKyVKjaum_F8v4e8wapnFcK8w@mail.gmail.com>
X-Original-References	<1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1576497

Show key headers only | View raw

Hi,


On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen <peter.chen@nxp.com> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> For xhci-hcd platform device, all the DMA parameters are not
> configured properly, notably dma ops for dwc3 devices. So, set
> the dma for xhci from sysdev. sysdev is pointing to device that
> is known to the system firmware or hardware.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Tested-by: Baolin Wang <baolin.wang@linaro.org>
> Tested-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Tested-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---

This patch doesn't work for me anymore on db820c target [1].
While the same kernel with reverts of patches [2] [3] and an older
patch [4] by Grygorii Strashko works [5].

[1] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c-nonworking
[2] 8c9f2de459c7 usb: dwc3: Do not set dma coherent mask
[3] d64ff406e51e usb: dwc3: use bus->sysdev for DMA configuration
[4] https://lkml.org/lkml/2016/4/25/813
[5] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c


regards
Vivek

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-02-08 13:20 +0100
  Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration Peter Chen <hzpeterchen@gmail.com> - 2017-02-09 05:10 +0100

csiph-web