Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576415

Re: [PATCH] time: Remove CONFIG_TIMER_STATS

Show all headers | View raw

On Tue, 7 Feb 2017, John Stultz wrote:
> On Tue, Feb 7, 2017 at 3:40 PM, Kees Cook <keescook@chromium.org> wrote:
> > Currently CONFIG_TIMER_STATS exposes process information across namespaces:
> >
> > kernel/time/timer_list.c print_timer():
> >
> >         SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
> >
> > /proc/timer_list:
> >
> >  #11: <0000000000000000>, hrtimer_wakeup, S:01, do_nanosleep, cron/2570
> >
> > Given that the tracer can give the same information, this patch entirely
> > removes CONFIG_TIMER_STATS.
> >
> > Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> I don't have an issue with this, but I worry this would break some
> tooling out there. Should it be marked as deprecated first?
> 
> Or maybe just pulling the band-aid off is the best way?

I think we should just kill it.

No tools can really rely on the behaviour of that file because it depends
on CONFIG_TIMER_STATS and the information available there is just a random
snapshot of queued timers at a given point of time, which is in no way
usefull.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] time: Remove CONFIG_TIMER_STATS Kees Cook <keescook@chromium.org> - 2017-02-08 00:50 +0100
  Re: [PATCH] time: Remove CONFIG_TIMER_STATS John Stultz <john.stultz@linaro.org> - 2017-02-08 05:30 +0100
    Re: [PATCH] time: Remove CONFIG_TIMER_STATS Thomas Gleixner <tglx@linutronix.de> - 2017-02-08 11:30 +0100
      Re: [PATCH] time: Remove CONFIG_TIMER_STATS John Stultz <john.stultz@linaro.org> - 2017-02-08 19:10 +0100
  Re: [PATCH] time: Remove CONFIG_TIMER_STATS kbuild test robot <lkp@intel.com> - 2017-02-08 05:50 +0100

csiph-web