Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576316

Re: [PATCH v2] staging: rtl8712: rtl8712: fix sparse warnings

Show all headers | View raw

On Wed, Feb 08, 2017 at 01:23:15AM +0000, Carlos Palminha wrote:
> Fixed sparse warnings
> * No need to convert from le32, pointers for structure with same endianness (cast from restricted __le32)
> * Need to convert bitwise operation for le32 structure (invalid assignment from int to __le32)
> 
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> Changes v1->v2:
> * Clarify patch description to ensure confidence
> 
>  drivers/staging/rtl8712/rtl8712_xmit.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index c4f03a602a2e..67713643c923 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -561,19 +561,19 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
> 
>  			ptxdesc_mp = &txdesc_mp;
>  			/* offset 8 */
> -			ptxdesc->txdw2 = cpu_to_le32(ptxdesc_mp->txdw2);
> +			ptxdesc->txdw2 = ptxdesc_mp->txdw2;

Nah...  The original is done deliberately.  When I'm reviewing this
patch I can see that now.

Just leave this as-is.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-02-08 02:30 +0100
  Re: [PATCH v2] staging: rtl8712: rtl8712: fix sparse warnings Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-08 08:40 +0100

csiph-web