Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576203

Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
Date 2017-02-08 02:00 +0100
Message-ID <t8oM2-1D5-9@gated-at.bofh.it> (permalink)
References <t8oCl-1zo-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> Fixed the following sparse warnings:
> * cast from restricted __le32
> * invalid assignment from int to __le32
> 

The changelog doesn't give me any confidence that you understand the
implications of this patch.  You silenced the warning but I think you
may be introducing bugs (I haven't done a thourough review).

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-02-08 01:50 +0100
  Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-08 02:00 +0100
    Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-02-08 02:20 +0100
      Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-08 07:20 +0100

csiph-web