Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576163

Re: [PATCH 7/7] serial: exar: Enable MSI support

Show all headers | View raw

On Tue, Feb 7, 2017 at 6:10 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Use pci_alloc_irq_vectors to enable MSI when available. At least the
> XR17V352 supports this.
>

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> index 13cc1da..236de60 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -284,10 +284,16 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
>
>         priv->board = board;
>
> +       pci_set_master(pcidev);
> +
> +       rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
> +       if (rc < 0)
> +               return rc;
> +
>         memset(&uart, 0, sizeof(uart));
>         uart.port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF | UPF_SHARE_IRQ
>                           | UPF_EXAR_EFR;
> -       uart.port.irq = pcidev->irq;
> +       uart.port.irq = pci_irq_vector(pcidev, 0);
>         uart.port.dev = &pcidev->dev;
>
>         for (i = 0; i < nr_ports && i < maxnr; i++) {
> --
> 2.1.4
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] serial: exar: Fixes and cleanups Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
  [PATCH 5/7] serial: pci: Remove unused pci_boards entries Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
  [PATCH 7/7] serial: exar: Enable MSI support Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
    Re: [PATCH 7/7] serial: exar: Enable MSI support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-08 00:30 +0100
  [PATCH 4/7] serial: exar: Move Commtech adapters to 8250_exar as well Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
    Re: [PATCH 4/7] serial: exar: Move Commtech adapters to 8250_exar as well Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-08 00:30 +0100
      Re: [PATCH 4/7] serial: exar: Move Commtech adapters to 8250_exar as  well Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-08 08:10 +0100
  [PATCH 1/7] serial: exar: Fix mapping of port I/O resources Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
    Re: [PATCH 1/7] serial: exar: Fix mapping of port I/O resources Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-07 23:50 +0100
  [PATCH 6/7] serial: exar: Move register defines from uapi header to consumer site Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
  [PATCH 3/7] serial: exar: Fix feature control register constants Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 17:20 +0100
    Re: [PATCH 3/7] serial: exar: Fix feature control register constants Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-07 23:50 +0100

csiph-web