Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1576174

Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits
Date 2017-02-08 00:50 +0100
Message-ID <t8nGh-ZA-5@gated-at.bofh.it> (permalink)
References <t8dGX-3hn-53@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:

Arnd> Shifting a dma_addr_t right by 32 bits causes a compile-time
Arnd> warning when that type is only 32 bit wide:

Arnd> drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter':
Arnd> drivers/scsi/aacraid/src.c:414:29: error: right shift count >=
Arnd> width of type [-Werror=shift-count-overflow]

Arnd> This changes the driver to use the predefined macros consistently,
Arnd> including one correct but open-coded upper_32_bits() instance.

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: aacraid: avoid open-coded upper_32_bits Arnd Bergmann <arnd@arndb.de> - 2017-02-07 14:20 +0100
  Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-02-08 00:50 +0100

csiph-web