Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576028

Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse

Show all headers | View raw

On 02/06/2017 05:50 PM, Luc Van Oostenryck wrote:
> On Mon, Feb 06, 2017 at 05:08:17PM -0800, Stephen Boyd wrote:
>> On 02/06/2017 05:01 PM, Stephen Boyd wrote:
>>> When I compile files with sparse, I get these sorts of warnings:
>>>
>>> arch/arm64/include/asm/lse.h:14:28: warning: Unknown escape 'l'
>>> arch/arm64/include/asm/lse.h:14:37: warning: Unknown escape 'l'
>>> arch/arm64/include/asm/alternative.h:172:28: warning: Unknown escape 'o'
>>>
>>> This is because sparse is trying to tokenize these files and sees
>>> a line like this:
>>>
>>>  alternative_insn "\llsc", "\lse", ARM64_HAS_LSE_ATOMICS
>>>
>>> It gets past alternative_insn part and then sees the start of a
>>> string with the double quote character. So sparse starts to parse
>>> the string (eat_string() in the sparse code) but the string has
>>> an escape character '\' in it. Sparse sees the escape character,
>>> so it checks to see if it's an escape sequence, but '\l' isn't.
>>> This causes sparse to spit out this warning of an unknown escape
>>> sequence 'l'.
>>>
>>> In reality, sparse isn't going to use these macros anyway because
>>> this whole thing is inside an __ASSEMBLER__ ifdef.
> Yes, annoying. Conversion of escaped characters is supposed to be
> done just after preprocessing. It's definitively a bug.

Ok. Thanks for the fixes to sparse. My hack patch can be safely ignored.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/PATCH] arm64: Rename macro arguments to silence sparse Stephen Boyd <sboyd@codeaurora.org> - 2017-02-07 02:10 +0100
  Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse Stephen Boyd <sboyd@codeaurora.org> - 2017-02-07 02:10 +0100
    Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse Luc Van Oostenryck <luc.vanoostenryck@gmail.com> - 2017-02-07 03:00 +0100
      Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse Stephen Boyd <sboyd@codeaurora.org> - 2017-02-07 21:30 +0100
        Re: [RFC/PATCH] arm64: Rename macro arguments to silence sparse Van Oostenryck Luc <luc.vanoostenryck@gmail.com> - 2017-02-07 21:40 +0100

csiph-web