Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications
Date	2017-02-07 19:00 +0100
Message-ID	<t8idA-5XI-15@gated-at.bofh.it> (permalink)
References	<t7Y5c-1m6-9@gated-at.bofh.it> <t7Y5d-1m6-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Date: Mon, 6 Feb 2017 21:20:33 +0100

>  
>  	/* Validate the protocol  - only support UMTS for now */
> -	if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) {
> +	if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) {
 ...
> +	} else if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS_DS) {
> +		expected_length = SIERRA_NET_LSI_UMTS_DS_STATUS_LEN;

If you are now supporting more protocols, that comment is not correct
any longer.  You therefore need to update it or remove it.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-02-06 21:30 +0100
  Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack  Link Sense Indications David Miller <davem@davemloft.net> - 2017-02-07 19:00 +0100

csiph-web