Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575780

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

Show all headers | View raw

On Tue 07-02-17 18:46:55, vinayak menon wrote:
> On Tue, Feb 7, 2017 at 5:47 PM, Michal Hocko <mhocko@kernel.org> wrote:
> > On Tue 07-02-17 16:39:15, vinayak menon wrote:
[...]
> >> Starting to kill at the right time helps in recovering memory at a
> >> faster rate than waiting for the reclaim to complete. Yes, we may
> >> be able to modify lowmemorykiller to cope with this problem. But
> >> the actual problem this patch tried to fix was the vmpressure event
> >> regression.
> >
> > I am not happy about the regression but you should try to understand
> > that we might end up with another report a month later for a different
> > consumer of events.
>
> I understand that. But this was the way vmpressure had worked until the
> regression and IMHO adding reclaimed slab just increases the noise in
> vmpressure.

I would argue the previous behavior was wrong as well.

> > I believe that the vmpressure needs some serious rethought and come with
> > a more realistic and stable metric.
>
> Okay. I agree. So you are suggesting to drop the patch ?

Unless there is a strong reason to keep it. Your test case seems to be
rather artificial and the behavior is not much better after your patch.
So rather than tunning the broken behavior for a particular test case
I would welcome rethinking the whole thing.

That being said I am not nacking the patch so if others think that this
is a reasonable thing to do for now I will not stand in the way.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure Vinayak Menon <vinmenon@codeaurora.org> - 2017-02-06 13:30 +0100
  [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on underflow Vinayak Menon <vinmenon@codeaurora.org> - 2017-02-06 13:30 +0100
    Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on  underflow Michal Hocko <mhocko@kernel.org> - 2017-02-06 13:50 +0100
      Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on underflow vinayak menon <vinayakm.list@gmail.com> - 2017-02-06 14:10 +0100
        Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on  underflow Michal Hocko <mhocko@kernel.org> - 2017-02-06 14:30 +0100
          Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on underflow vinayak menon <vinayakm.list@gmail.com> - 2017-02-06 15:40 +0100
            Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on  underflow Michal Hocko <mhocko@kernel.org> - 2017-02-06 16:20 +0100
              Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on underflow vinayak menon <vinayakm.list@gmail.com> - 2017-02-07 12:20 +0100
                Re: [PATCH 2/2 RESEND] mm: vmpressure: fix sending wrong events on  underflow Michal Hocko <mhocko@kernel.org> - 2017-02-07 13:20 +0100
  Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-06 14:00 +0100
    Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-06 16:20 +0100
      Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-07 09:20 +0100
        Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-07 12:10 +0100
          Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-07 13:20 +0100
            Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure vinayak menon <vinayakm.list@gmail.com> - 2017-02-07 14:20 +0100
              Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to  vmpressure Michal Hocko <mhocko@kernel.org> - 2017-02-07 16:00 +0100

csiph-web