Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575622

Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote:
> From: Tomasz Figa <tfiga@chromium.org>
> 
> When converting the driver to use shmem-backed GEMs for IOMMU-enabled
> systems, we forgot to add calls to drm_gem_object_release(), which gave
> us a quite nice memory leak. This patch adds the missing calls.
> 
> Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use DMA mapping API if
> attached to IOMMU domain")
> 
> TEST=while true; do backlight_dbus_tool --set --percent=0 && sleep 8 &&
>  backlight_dbus_tool --set --percent=100 && sleep 3 ; done

Ugh... please clean up your commit messages before posting to the
mailing list. FROMLIST: patches clearly aren't what will be merged
upstream and the SHA1 isn't going to match, so nobody but you will
find this anywhere.

> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> Reviewed-on: https://chromium-review.googlesource.com/385456

This is also present in some of the patches you posted, but it's not
typical for these to be included in upstream patches because usually
by the time patches from some gerrit make it to upstream, upstream
can have diverged significantly enough for the review to no longer
apply.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Mark Yao <mark.yao@rock-chips.com> - 2017-02-07 09:40 +0100
  [PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap Mark Yao <mark.yao@rock-chips.com> - 2017-02-07 09:40 +0100
    Re: [PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap Thierry Reding <thierry.reding@gmail.com> - 2017-02-07 13:40 +0100
  [PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain Mark Yao <mark.yao@rock-chips.com> - 2017-02-07 09:40 +0100
  [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base Mark Yao <mark.yao@rock-chips.com> - 2017-02-07 09:40 +0100
    Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to  destroy GEM base Thierry Reding <thierry.reding@gmail.com> - 2017-02-07 13:40 +0100
      Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to  destroy GEM base Tomasz Figa <tfiga@chromium.org> - 2017-02-07 14:10 +0100
  Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64  iommu Thierry Reding <thierry.reding@gmail.com> - 2017-02-07 13:40 +0100
    Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64  iommu Mark yao <mark.yao@rock-chips.com> - 2017-02-08 02:20 +0100
  Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Heiko Stübner <heiko@sntech.de> - 2017-02-09 00:40 +0100

csiph-web