Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero
Date	2017-02-07 12:40 +0100
Message-ID	<t8chQ-2ff-25@gated-at.bofh.it> (permalink)
References	<t8c8a-2bv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 07, 2017 at 11:27:38AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The check on rcode >= 0 is always true because rcode is unsigned
> and can never be less than zero.  Remove the redundant check.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/scsi/aacraid/aachba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 3b5ddf4..ddfd726 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
>  			FsaNormal, 1, 1, NULL, NULL);
>  
>  	/* analyse data */
> -	if (rcode >= 0 && phys_luns->resp_flag == 2) {

The original code is buggy.  rcode should be an int.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero Colin King <colin.king@canonical.com> - 2017-02-07 12:30 +0100
  Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less  than zero Colin Ian King <colin.king@canonical.com> - 2017-02-07 12:40 +0100
  Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less  than zero Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-07 12:40 +0100

csiph-web