[PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe()
Date	2017-02-09 16:30 +0100
Message-ID	<t8YPv-7PX-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/memory/da8xx-ddrctl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/da8xx-ddrctl.c b/drivers/memory/da8xx-ddrctl.c
index 030afbe..3286aee 100644
--- a/drivers/memory/da8xx-ddrctl.c
+++ b/drivers/memory/da8xx-ddrctl.c
@@ -122,10 +122,8 @@ static int da8xx_ddrctl_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ddrctl = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ddrctl)) {
-		dev_err(dev, "unable to map memory controller registers\n");
+	if (IS_ERR(ddrctl))
 		return PTR_ERR(ddrctl);
-	}
 
 	for (; setting->name; setting++) {
 		knob = da8xx_ddrctl_match_knob(setting);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:30 +0100
  Re: [PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call  in da8xx_ddrctl_probe() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-09 17:50 +0100

csiph-web