Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577538

Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config

Show all headers | View raw

On 27/01/17 15:55, Cheah Kok Cheong wrote:
> Currently user can input any value for amplitude and period.
> This patch set a sane max value for auto-configuration mode.
>
> For manual configuration mode, it is assumed this is taken care of
> by the COMEDI userspace tool since there's no limit set here from
> day one in the staging tree. If otherwise then maybe this can be
> looked at separately.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>

I don't think there is any need to limit these unless it results in 
arithmetic overflow, since they only affect the fake sample data values 
produced by the driver, not system performance.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input  value for auto config Ian Abbott <abbotti@mev.co.uk> - 2017-02-09 13:40 +0100
  Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input  value for auto config Cheah Kok Cheong <thrust73@gmail.com> - 2017-02-11 10:30 +0100

csiph-web