Re: [PATCH] staging: comedi: Fix incorrect type assignment

From	Karthik Nayak <karthik.188@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: comedi: Fix incorrect type assignment
Date	2017-02-09 12:40 +0100
Message-ID	<t8VeW-5zl-13@gated-at.bofh.it> (permalink)
References	<t8H2h-4VH-9@gated-at.bofh.it> <t8H2h-4VH-7@gated-at.bofh.it> <t8V5g-5vY-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Thu, Feb 9, 2017 at 4:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    expected restricted __be32 [usertype] serial_number
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    got unsigned int
>>
>> This is done by removing the whole code block, since the variable
>> 'serial_number' is only assigned but never used.
>>
>> Helped-by: Ian Abbott <abbotti@mev.co.uk>
>
> There's no such tag, sorry :(
>

Ah! This is common back in the Git community, I shall drop it :)

> And does this obsolete all of your other ones?  Please make it obvious
> what I am supposed to do here.
>
> I've now dropped all of these patches from my queue.  please resend the
> proper one.
>

That works! I'll send the patch again, lets ignore the previous patches.


On Thu, Feb 9, 2017 at 4:52 PM, Ian Abbott <abbotti@mev.co.uk> wrote:
> To add to that, I think the emphasis of the patch title and description
> should now be on the removal of serial_number, with fixing the sparse error
> as a useful side-effect/inspiration.  The patch title should also mention
> ni_pcimio.
>
> Thanks,
> Ian.

Makes sense, will make the necessary changes.


-- 
Regards,
Karthik Nayak

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: Fix incorrect type assignment Karthik Nayak <karthik.188@gmail.com> - 2017-02-08 21:30 +0100
  Re: [PATCH] staging: comedi: Fix incorrect type assignment Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 12:30 +0100
    Re: [PATCH] staging: comedi: Fix incorrect type assignment Ian Abbott <abbotti@mev.co.uk> - 2017-02-09 12:40 +0100
    Re: [PATCH] staging: comedi: Fix incorrect type assignment Karthik Nayak <karthik.188@gmail.com> - 2017-02-09 12:40 +0100

csiph-web