[PATCH 3/5] selftests: Fix the .S and .S -> .o rules

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	[PATCH 3/5] selftests: Fix the .S and .S -> .o rules
Date	2017-02-09 10:10 +0100
Message-ID	<t8STL-4gx-19@gated-at.bofh.it> (permalink)
References	<t8STL-4gx-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Both these rules incorrectly use $< (first prerequisite) rather than
$^ (all prerequisites), meaning they don't work if we're using more than
one .S file as input. Switch them to using $^.

They also don't include $(CPPFLAGS) and other variables used in the
default rules, which breaks targets that require those. Fix that by
using the builtin $(COMPILE.S) and $(LINK.S) rules.

Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 tools/testing/selftests/lib.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 98841c54763a..ce96d80ad64f 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -54,9 +54,9 @@ $(OUTPUT)/%:%.c
 	$(LINK.c) $^ $(LDLIBS) -o $@
 
 $(OUTPUT)/%.o:%.S
-	$(CC) $(ASFLAGS) -c $< -o $@
+	$(COMPILE.S) $^ -o $@
 
 $(OUTPUT)/%:%.S
-	$(CC) $(ASFLAGS) $< -o $@
+	$(LINK.S) $^ $(LDLIBS) -o $@
 
 .PHONY: run_tests all clean install emit_tests
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3/5] selftests: Fix the .S and .S -> .o rules Michael Ellerman <mpe@ellerman.id.au> - 2017-02-09 10:10 +0100

csiph-web