Re: [PATCH v5 1/4] usb: dbc: early driver for xhci debug capability

From	Lu Baolu <baolu.lu@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/4] usb: dbc: early driver for xhci debug capability
Date	2017-02-09 08:40 +0100
Message-ID	<t8RuF-3aL-5@gated-at.bofh.it> (permalink)
References	(6 earlier) <t3swW-6x-23@gated-at.bofh.it> <t3uS6-1Hz-15@gated-at.bofh.it> <t3wTT-2VB-9@gated-at.bofh.it> <t3y9k-3Do-25@gated-at.bofh.it> <t3MFj-4sB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ingo,

On 01/26/2017 03:22 PM, Ingo Molnar wrote:
> * Lu Baolu <baolu.lu@linux.intel.com> wrote:
>
>> Hi,
>>
>> On 01/25/2017 10:38 PM, Peter Zijlstra wrote:
>>> On Wed, Jan 25, 2017 at 08:27:38PM +0800, Lu Baolu wrote:
>>>> In my driver, udelay() is mostly used to handle time out.
>>>>
>>>> Xdbc hides most USB things in its firmware. Early printk driver only needs
>>>> to setup the registers/data structures and wait until link ready or time out.
>>>> Without udelay(), I have no means to convert the polling times into waiting
>>>> time.
>>> What is timeout and why?
>> Put it in simple:
>>
>> The driver sets the RUN bit in control register and polls READY
>> bit in status register for the successful USB device enumeration.
>> As the USB device enumeration might fail and the READY bit will
>> never be set, the driver must have a timeout logic to avoid
>> endless loop.
> Is there any error status available in the host registers anywhere that tells us 
> that enumeration did not succeed?

No, there isn't. The xhci spec requires software to impose a timeout.

Page 425, xhci specification:

"
Software shall impose a timeout between the detection
of the Debug Host connection and the DbC Run transition
to ‘1’.
"

Best regards,
Lu Baolu

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/4] usb: dbc: early driver for xhci debug capability Lu Baolu <baolu.lu@linux.intel.com> - 2017-02-09 08:40 +0100

csiph-web