Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write()

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write()
Date	2017-02-09 03:30 +0100
Message-ID	<t8MEG-8rI-9@gated-at.bofh.it> (permalink)
References	<sLrzk-4WB-51@gated-at.bofh.it> <sM97k-7Se-55@gated-at.bofh.it> <sNYKt-3R9-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 13, 2016 at 05:43:52PM +0100, Cyrille Pitchen wrote:
> Le 08/12/2016 à 16:31, Boris Brezillon a écrit :
> > On Tue, 6 Dec 2016 18:14:24 +0100
> > Cyrille Pitchen <cyrille.pitchen@atmel.com> wrote:
> > 
> >> This patch removes the WARN_ONCE() test in spi_nor_write().
> >> This macro triggers the display of a warning message almost every time we
> >> use a UBI file-system because a write operation is performed at offset 64,
> >> which is in the middle of the SPI NOR memory page. This is a valid
> >> operation for ubifs.
> >>
> >> Hence this warning is pretty annoying and useless so we just remove it.
> >>
> >> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> >> Suggested-by: Richard Weinberger <richard@nod.at>
> >> Suggested-by: Andras Szemzo <szemzo.andras@gmail.com>
> > 
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > 
> Applied to git://github.com/spi-nor/linux.git

Do you have any idea on how to handle or communicate this better? I
recall Michal added this because he was adding new write looping that
didn't previously exist; we might create partial-page writes because his
SPI controller was too dumb to make larger ones.

Anyway, since this is hitting real (and more or less false positive)
use cases, then this patch is probably good.

Brian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Brian Norris <computersforpeace@gmail.com> - 2017-02-09 03:30 +0100
  Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-02-09 15:00 +0100
    Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Brian Norris <computersforpeace@gmail.com> - 2017-02-10 19:40 +0100

csiph-web