Re: [PATCH v1 2/3] dt: Document for the ZTE zx296718 I2S controller

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/3] dt: Document for the ZTE zx296718 I2S controller
Date	2017-02-09 01:50 +0100
Message-ID	<t8L5T-7nW-17@gated-at.bofh.it> (permalink)
References	<t7RZM-5F5-23@gated-at.bofh.it> <t7RZM-5F5-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 06, 2017 at 09:50:19PM +0800, Baoyou Xie wrote:
> This patch documents the devicetree for the ZTE's zx296718
> I2S audio controller.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  Documentation/devicetree/bindings/sound/zte,zx-i2s.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> index 7e5aa6f..c405561 100644
> --- a/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/zte,zx-i2s.txt
> @@ -1,10 +1,12 @@
>  ZTE ZX296702 I2S controller
>  
>  Required properties:
> - - compatible : Must be "zte,zx296702-i2s"
> + - compatible : Should include one of the following strings:
> +	"zte,zx296702-i2s","zte,zx296718-i2s".

One per line please.

>   - reg : Must contain I2S core's registers location and length
>   - clocks : Pairs of phandle and specifier referencing the controller's clocks.
> - - clock-names: "tx" for the clock to the I2S interface.
> + - clock-names: "tx" for the wclk, "pclk" for the pclk to the I2S interface.
> +	must contain pclk for zx296718 SoC.

I'd reword as "pclk is only present for zte,zx296718-i2s"

>   - dmas: Pairs of phandle and specifier for the DMA channel that is used by
>     the core. The core expects two dma channels for transmit.
>   - dma-names : Must be "tx" and "rx"
> -- 
> 2.7.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 2/3] dt: Document for the ZTE zx296718 I2S controller Baoyou Xie <baoyou.xie@linaro.org> - 2017-02-06 15:00 +0100
  Re: [PATCH v1 2/3] dt: Document for the ZTE zx296718 I2S controller Mark Brown <broonie@kernel.org> - 2017-02-06 17:40 +0100
  Re: [PATCH v1 2/3] dt: Document for the ZTE zx296718 I2S controller Rob Herring <robh@kernel.org> - 2017-02-09 01:50 +0100

csiph-web