Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577154

Re: [PATCH] mtd: ichxrom: maybe-uninitialized with gcc-4.9

Show all headers | View raw

On Mon, Oct 24, 2016 at 10:47:59PM +0200, Marek Vasut wrote:
> On 10/24/2016 05:28 PM, Arnd Bergmann wrote:
> > pci_read_config_word() might fail and not initialize its output,
> > as pointed out by older versions of gcc when using the -Wmaybe-unintialized
> > flag:
> > 
> > drivers/mtd/maps/ichxrom.c: In function ‘ichxrom_cleanup’:
> > drivers/mtd/maps/ichxrom.c:63:2: error: ‘word’ is used uninitialized in this function [-Werror=uninitialized]
> > 
> > This is apparently a correct warning, though it does not show up
> > with newer compilers. Changing the code to not attempt to write
> > back uninitialized data into PCI config space is a correct
> > fix for the problem and avoids the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Marek Vasut <marex@denx.de>

Applied to l2-mtd.git

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: ichxrom: maybe-uninitialized with gcc-4.9 Brian Norris <computersforpeace@gmail.com> - 2017-02-08 23:30 +0100

csiph-web