Re: [PATCH] xenbus: Neaten xenbus_va_dev_error

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xenbus: Neaten xenbus_va_dev_error
Date	2017-02-08 19:30 +0100
Message-ID	<t8Faa-3KK-27@gated-at.bofh.it> (permalink)
References	<t8zxL-h3-1@gated-at.bofh.it> <t8CP0-2b0-19@gated-at.bofh.it> <t8D8m-2x9-3@gated-at.bofh.it> <t8Ee7-3aO-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-02-08 at 12:14 -0500, Boris Ostrovsky wrote:
> On 02/08/2017 11:05 AM, Joe Perches wrote:
> > On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote:
> > > On 02/08/2017 06:33 AM, Joe Perches wrote:
> > > > This function error patch can be simplified, so do so.
> > > > 
> > > > Remove fail: label and somewhat obfuscating, used once "error_path"
> > > > function.
> > 
> > btw: I left it alone, but likely
> > 
> > #define PRINTF_BUFFER_SIZE 4096
> > 
> > is probably excessive as the maximum printk
> > buffer is 1024.
> > 
> > The xenbus_write might be longer though so
> > maybe it's OK to use 4096, but there is some
> > inequivalence there.
> > 
> 
> xenbus_write() handles writes up to 4K. However we are filling the
> buffer with sprintf() which I assume is limited to 1K too

vsnprintf is bounded only by addressable memory. ie: (void *)-1

> so it indeed
> doesn't seem useful to have PRINTF_BUFFER_SIZE set to 4.
> 
> -boris
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xenbus: Neaten xenbus_va_dev_error Joe Perches <joe@perches.com> - 2017-02-08 13:30 +0100
  Re: [PATCH] xenbus: Neaten xenbus_va_dev_error Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-08 17:00 +0100
    Re: [PATCH] xenbus: Neaten xenbus_va_dev_error Joe Perches <joe@perches.com> - 2017-02-08 17:20 +0100
      Re: [PATCH] xenbus: Neaten xenbus_va_dev_error Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-08 18:30 +0100
        Re: [PATCH] xenbus: Neaten xenbus_va_dev_error Joe Perches <joe@perches.com> - 2017-02-08 19:30 +0100

csiph-web