Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1576800

Re: [PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth
Date 2017-02-08 19:20 +0100
Message-ID <t8F0u-3Hv-29@gated-at.bofh.it> (permalink)
References <t7X98-Lb-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Mon,  6 Feb 2017 22:24:45 +0300

> Given there're default values mentioned in the PHY datasheet
> fall-back gracefully to them instead of silently return an error
> through the whole call-chain.
> 
> This allows to use minimalistic description in DT if no special
> features are required.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

If these defaults are legitimate to use, then you should probably also
set them in the non-CONFIG_OF_MDIO case implementation of
dp83867_of_init().

But I'd like to see feedback and reviews from other PHY area experts
before I even consider that updated version of this change.

Thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-06 20:30 +0100
  Re: [PATCH] net: phy: dp83867: Fall-back to default values of  clock delay and FIFO depth David Miller <davem@davemloft.net> - 2017-02-08 19:20 +0100
    Re: [PATCH] net: phy: dp83867: Fall-back to default values of clock  delay and FIFO depth Florian Fainelli <f.fainelli@gmail.com> - 2017-02-08 19:30 +0100
      Re: [PATCH] net: phy: dp83867: Fall-back to default values of clock  delay and FIFO depth Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-09 21:30 +0100

csiph-web