Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1576754
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection |
| Date | 2017-02-08 18:30 +0100 |
| Message-ID | <t8Ee7-3aO-59@gated-at.bofh.it> (permalink) |
| References | <sQ8Po-1KN-9@gated-at.bofh.it> <sQ8Po-1KN-7@gated-at.bofh.it> <t8kfo-7qC-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/02/2017 20:58, Radim Krčmář wrote:
>> - local_irq_disable();
>> + if (kvm_lapic_enabled(vcpu)) {
>> + /*
>> + * This handles the case where a posted interrupt was
>> + * notified with kvm_vcpu_kick.
>> + */
>> + if (kvm_x86_ops->sync_pir_to_irr)
>> + kvm_x86_ops->sync_pir_to_irr(vcpu);
> Hm, this is not working well when nesting while L1 has assigned devices:
> if the posted interrupt arrives just before local_irq_disable(), then
> we'll just enter L2 instead of doing a nested VM exit (in case we have
> interrupt exiting).
>
> And after reading the code a bit, I think we allow posted interrupts in
> L2 while L1 has assigned devices that use posted interrupts, and that it
> doesn't work.
So you mean the interrupt is delivered to L2? The fix would be to wrap
L2 entry and exit with some subset of pi_pre_block/pi_post_block.
Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection Radim Krčmář <rkrcmar@redhat.com> - 2017-02-07 21:10 +0100
Re: [PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection Paolo Bonzini <pbonzini@redhat.com> - 2017-02-08 18:30 +0100
Re: [PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection Radim Krčmář <rkrcmar@redhat.com> - 2017-02-09 16:20 +0100
csiph-web