Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1576714

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

From "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion
Date 2017-02-08 17:50 +0100
Message-ID <t8DBp-2Hv-35@gated-at.bofh.it> (permalink)
References <t8e0i-3oO-3@gated-at.bofh.it> <t8e0j-3oO-27@gated-at.bofh.it> <t8mKe-q3-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote:
> On Tue, Feb 07, 2017 at 01:17:46PM +0000, Nicholas A. Bellinger wrote:
> > +		if (orig->se_lun_acl != NULL) {
> > +			pr_warn_ratelimited("Detected existing explicit"
> > +				" se_lun_acl->se_lun_group reference for %s"
> > +				" mapped_lun: %llu, ignoring\n",
> > +				 nacl->initiatorname, mapped_lun);
> 
> The ignoring in the message confused the heck out of me first.  But it 
> seems that's just an incorrect leftover from the original message, as the
> changelog also says fail instead.  With that fixed up (and maybe the
> whole message in a single string literal on a single line):
> 

Fixed up the message to use 'failed'.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] target: Miscellaneous bug-fixes for >= v4.10 "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
  [PATCH 2/5] target: Use correct SCSI status during EXTENDED_COPY exception "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
    Re: [PATCH 2/5] target: Use correct SCSI status during EXTENDED_COPY  exception Christoph Hellwig <hch@infradead.org> - 2017-02-07 23:40 +0100
  [PATCH 3/5] target: Fix early transport_generic_handle_tmr abort scenario "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
    Re: [PATCH 3/5] target: Fix early transport_generic_handle_tmr abort  scenario Christoph Hellwig <hch@infradead.org> - 2017-02-07 23:50 +0100
  [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
    Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double  free OOPs Christoph Hellwig <hch@infradead.org> - 2017-02-08 00:10 +0100
      Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double  free OOPs Christoph Hellwig <hch@infradead.org> - 2017-02-08 00:20 +0100
        Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl  double free OOPs "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-08 05:00 +0100
          Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl  double free OOPs "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-08 17:20 +0100
  [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
    Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic ->  explicit conversion Christoph Hellwig <hch@infradead.org> - 2017-02-07 23:50 +0100
      Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic ->  explicit conversion "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-08 17:50 +0100
  [PATCH 5/5] target: Fix COMPARE_AND_WRITE ref leak for non GOOD status "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-02-07 14:30 +0100
    Re: [PATCH 5/5] target: Fix COMPARE_AND_WRITE ref leak for non GOOD  status Christoph Hellwig <hch@infradead.org> - 2017-02-08 00:00 +0100

csiph-web