Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

From	Shanker Donthineni <shankerd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation
Date	2017-02-08 16:40 +0100
Message-ID	<t8CvE-240-27@gated-at.bofh.it> (permalink)
References	<t8BJg-1xy-25@gated-at.bofh.it> <t8BJg-1xy-27@gated-at.bofh.it> <t8BJg-1xy-23@gated-at.bofh.it> <t8CvE-240-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marc,

In teardown path, code is still calling 'kfree(its->cmd_base)' to free 
memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ).


On 02/08/2017 08:43 AM, Robert Richter wrote:
> On 08.02.17 14:41:18, Marc Zyngier wrote:
>> On Wed, Feb 01 2017 at  5:38:25 pm GMT, Robert Richter
> <rrichter@cavium.com> wrote:
>>> The its command buffer must be page aligned, but kzalloc() is not
>>> guaranteed to be (though it is mostly when allocating 64k). Use
>>> __get_free_pages() as this is used for other buffers as well.
>>>
>>> Signed-off-by: Robert Richter <rrichter@cavium.com>
>> I'm still going through this series, but as this is an obvious fix, I've
>> cherry-picked it for 4.11.
> That was actually my intention, thus I placed it first.
>
> -Robert
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Thread

Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Marc Zyngier <marc.zyngier@arm.com> - 2017-02-08 15:50 +0100
  Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Shanker Donthineni <shankerd@codeaurora.org> - 2017-02-08 16:40 +0100
    Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Marc Zyngier <marc.zyngier@arm.com> - 2017-02-08 17:10 +0100
    Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Marc Zyngier <marc.zyngier@arm.com> - 2017-02-08 20:40 +0100

csiph-web