Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576636

Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface

From Joerg Roedel <joro@8bytes.org>
Newsgroups linux.kernel
Subject Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface
Date 2017-02-08 16:00 +0100
Message-ID <t8BzA-1u7-23@gated-at.bofh.it> (permalink)
References <t7Ubg-7e3-5@gated-at.bofh.it> <t8ddT-2Qi-7@gated-at.bofh.it> <t7Ubg-7e3-19@gated-at.bofh.it> <t8ddT-2Qi-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Marek,

On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote:
> >+	ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL,
> >+				     "sysmmu.%pa", &ioaddr);
> 
> Can we stick to the common name across the /sysfs and use
> dev_name(data->sysmmu)
> or even dev_name(dev) here?
> 
> ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL,
> dev_name(dev));

That means that we have multiple 'struct device' with the same name,
no? I think will lead to confusion when using dev_printk, as its not
clear anymore which device is refered to in the message.


	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10 v2] Let IOMMU core know about individual IOMMUs Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 02/10] iommu: Rename struct iommu_device Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
    Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register  interface Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-07 13:40 +0100
      Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register  interface Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-08 15:40 +0100
      Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register  interface Joerg Roedel <joro@8bytes.org> - 2017-02-08 16:00 +0100
  [PATCH 06/10] iommu/arm-smmu: Make use of the iommu_register interface Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 03/10] iommu: Introduce new 'struct iommu_device' Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 10/10] iommu: Remove iommu_register_instance interface Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 08/10] iommu/mediatek: Make use of iommu_device_register interface Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100
  [PATCH 04/10] iommu: Add sysfs bindings for struct iommu_device Joerg Roedel <joro@8bytes.org> - 2017-02-06 17:20 +0100

csiph-web