Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display
Date	Wed, 08 Feb 2017 14:30:03 +0100
Message-ID	<t8AtR-Rq-43@gated-at.bofh.it> (permalink)
References	<t8h7P-5ki-3@gated-at.bofh.it> <t8h7Q-5ki-7@gated-at.bofh.it> <t8iGB-6nr-13@gated-at.bofh.it>
X-Original-To	Kevin Hilman <khilman@baylibre.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0C4klKa0ge9So3Me6bJCK32UfyTOyW0B131vbYqCv3k=; b=Dm/Fxwdr0Ukh9lRhAkTTO4sGDV0jJ/JPQDldIZMsIBBr6BL8zMvKrpGyMbZxbRiNUb OZzfbiD3Wra+oGO3fMg02oU79BFtrz65uUMAiCGtdMrSs4gcfZrjWS7ZqoG6QhDL5jCt hEsddPsT21eazIVrvcTIbMoIBJ7u1wOAuUVaX+sl2tZedb5f79QAoWJ9vhMR9NA9sIcM jZBaVO+d51qOiEwHYzOWEu+u4JrEo2GAgOor3zpAaJvgMI+rVyaY0aOF9rzQup1nuc52 YmvqIuoa3MO3Act0IphjPSm+xTXCzY0of5kFZ42yJ7E8A1ujK5mS3/WecSjD5xXNsyaI Xczg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0C4klKa0ge9So3Me6bJCK32UfyTOyW0B131vbYqCv3k=; b=LlP7cvTqKTM09Ricrh+8Nnlwsrpp/YiuzbzBawWWVFplwq84uSDEK349AyVi59Ip8e iY6IBh4lG/rNtSKxXQzKlnD+l2sgM3JpO3n8gCmZSLWg0zfa9Caib/sbBM7kJS3nCrWP k62lfJq7RU+yhrNNjTx9oSRfEjfXxOWzkI5ahSwIhVTCuph/k8P9le8db2ApgeyTBCIC vi0bNkDBbjKDfdB9y3AvlRp1F/Zs2Z4MmJm+OC9gbeAZHey+AOLfH4UoSEK4+GdDZv8I fctW2tdzYeBWRlvWIZpc6yz5CmYq+sTGWMdZoH5uSHkQEDhbK74P7R4m9R8NARqrk66v YTbg==
X-Gm-Message-State	AIkVDXKH0C0ZmfK8SRw/CSWBG41cu51b0J3kX7cSgeXhaDLgu2pFudkUYz3IEIRqKm/BSpeLqrBvPF1nK7LUjA2Z
X-Received	by 10.36.83.14 with SMTP id n14mr17441514itb.16.1486560366592; Wed, 08 Feb 2017 05:26:06 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
X-Original-Cc	Sekhar Nori <nsekhar@ti.com>, Patrick Titiano <ptitiano@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Alexandre Bailon <abailon@baylibre.com>, David Lechner <david@lechnology.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Lad Prabhakar <prabhakar.csengg@gmail.com>, linux-devicetree <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org>, linux-media@vger.kernel.org
X-Original-Date	Wed, 8 Feb 2017 14:26:06 +0100
X-Original-Message-ID	<CAMpxmJUEH4-bP-x06fvYSy-6ViVMr3++txBQmtm5bEENR1yqnw@mail.gmail.com>
X-Original-References	<1486485683-11427-1-git-send-email-bgolaszewski@baylibre.com> <1486485683-11427-11-git-send-email-bgolaszewski@baylibre.com> <m2k291kglb.fsf@baylibre.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1576583

Show key headers only | View raw

2017-02-07 19:20 GMT+01:00 Kevin Hilman <khilman@baylibre.com>:
> Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>
>> Similarly to vpif capture: we need to register the vpif display driver
>> and the corresponding adv7343 encoder in pdata-quirks as the DT
>> support is not complete.
>
> To add a bit more detail to the changelog:  DT support is not complete
> since there isn't currently a way to define the output_routing in the
> V4L2 drivers (c.f. s_routing) via DT.
>

I'll add this in v2.

>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> minor nit below, otherwise
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>
>> ---
>>  arch/arm/mach-davinci/pdata-quirks.c | 86 +++++++++++++++++++++++++++++++++++-
>>  1 file changed, 85 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
>> index 09f62ac..0a55546 100644
>> --- a/arch/arm/mach-davinci/pdata-quirks.c
>> +++ b/arch/arm/mach-davinci/pdata-quirks.c
>> @@ -9,13 +9,17 @@
>>   */
>>  #include <linux/kernel.h>
>>  #include <linux/of_platform.h>
>> +#include <linux/gpio.h>
>>
>>  #include <media/i2c/tvp514x.h>
>> +#include <media/i2c/adv7343.h>
>>
>>  #include <mach/common.h>
>>  #include <mach/da8xx.h>
>>  #include <mach/mux.h>
>>
>> +#define DA850_EVM_UI_EXP_SEL_VPIF_DISP 5
>> +
>>  struct pdata_init {
>>       const char *compatible;
>>       void (*fn)(void);
>> @@ -107,7 +111,78 @@ static struct vpif_capture_config da850_vpif_capture_config = {
>>       },
>>       .card_name = "DA850/OMAP-L138 Video Capture",
>>  };
>> +#endif /* IS_ENABLED(CONFIG_VIDEO_DAVINCI_VPIF_CAPTURE) */
>> +
>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT)
>
> Why not IS_ENABLED(CONFIG_VIDEO_DAVINCI_VPIF_CAPTURE) also here?

Just a reflex ;)

I'll fix this too.

Thanks,
Bartosz

Thread

[PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
  Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display Kevin Hilman <khilman@baylibre.com> - 2017-02-07 19:30 +0100
    Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-08 14:30 +0100
  Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display Kevin Hilman <khilman@baylibre.com> - 2017-02-10 20:50 +0100

csiph-web