Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576548

Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info
Date 2017-02-08 14:10 +0100
Message-ID <t8Aav-Kl-49@gated-at.bofh.it> (permalink)
References <t8vXc-6oU-27@gated-at.bofh.it> <t8vXd-6oU-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 08, 2017 at 02:01:49PM +0530, Hari Bathini wrote:

SNIP

> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index ffac8ca..1946a17 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -875,6 +875,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
>  	signal(SIGTERM, sig_handler);
>  	signal(SIGSEGV, sigsegv_handler);
>  
> +	if (rec->opts.record_namespaces)
> +		tool->namespace_events = true;

should we do this by default? seems like low traffic event
with info that should be always present

also in case we keep the --namespace option, please add
it to the record's doc

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/3] perf: add support for analyzing events for containers Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-02-08 09:40 +0100
  [PATCH v6 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-02-08 09:40 +0100
  [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-02-08 09:40 +0100
    Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Jiri Olsa <jolsa@redhat.com> - 2017-02-08 14:10 +0100
    Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Jiri Olsa <jolsa@redhat.com> - 2017-02-08 14:10 +0100
    Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Jiri Olsa <jolsa@redhat.com> - 2017-02-08 14:10 +0100
  [PATCH v6 3/3] perf tool: add cgroup identifier entry in perf report Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-02-08 09:40 +0100

csiph-web