[PATCH 2/2] spi: s3c64xx: fix potential division by zero

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] spi: s3c64xx: fix potential division by zero
Date	2017-02-07 09:20 +0100
Message-ID	<t89ai-kj-23@gated-at.bofh.it> (permalink)
References	<t89ai-kj-25@gated-at.bofh.it> <t89ai-kj-27@gated-at.bofh.it> <t89ai-kj-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Even though it's quite unlikely to happen in this particular
case, clk_get_rate can return '0' if sdd->src_clk is not set
properly. In that case we would have a clear division by '0'.

Check the return value of clk_get_rate and fail in case it
returns '0'.

This patch fixes '1397922 Division or modulo by zero' from
scan.coverity.com

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/spi/spi-s3c64xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f6ea9ae047ec..a2ec07f44e33 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -811,6 +811,8 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
 
 		/* Max possible */
 		speed = clk_get_rate(sdd->src_clk) / 2 / (0 + 1);
+		if (!speed)
+			goto setup_exit;
 
 		if (spi->max_speed_hz > speed)
 			spi->max_speed_hz = speed;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] spi: s3c64xx: fix potential division by zero Andi Shyti <andi.shyti@samsung.com> - 2017-02-07 09:20 +0100
  Re: [PATCH 2/2] spi: s3c64xx: fix potential division by zero Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-07 21:50 +0100
    Re: [PATCH 2/2] spi: s3c64xx: fix potential division by zero Andi Shyti <andi.shyti@samsung.com> - 2017-02-08 06:40 +0100

csiph-web