Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper
Date	2017-02-07 09:10 +0100
Message-ID	<t890C-gF-23@gated-at.bofh.it> (permalink)
References	<t7RGp-5x6-3@gated-at.bofh.it> <t7RGt-5x6-111@gated-at.bofh.it> <t7SVP-6g8-11@gated-at.bofh.it> <t7ZDY-2rk-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 06, 2017 at 11:03:08PM +0100, Ingo Molnar wrote:
> 
> * Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > > +++ b/arch/powerpc/kernel/smp.c
> > > +++ b/arch/sparc/kernel/sysfs.c
> > > +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c
> > > +++ b/drivers/cpufreq/sparc-us3-cpufreq.c
> 
> > > -	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));
> > > +	cpumask_copy(&cpus_allowed, &current->cpus_allowed);
> > 
> > Note that all those, and this is where I stopped looking, appear broken vs 
> > userspace changing the mask right after.
> 
> But these are pre-existing bugs in code twidding ->cpus_allowed, not caused by my 
> patch, right?

Yes..

> I.e. my changes made you notice pre-existing bugs.

I think I spotted them when I made the tsk_cpus_allowed() thing as well.
Just wanted to call them out again.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper Ingo Molnar <mingo@kernel.org> - 2017-02-06 14:40 +0100
  Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper Peter Zijlstra <peterz@infradead.org> - 2017-02-06 16:00 +0100
  Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper Peter Zijlstra <peterz@infradead.org> - 2017-02-06 16:00 +0100
    Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper Ingo Molnar <mingo@kernel.org> - 2017-02-06 23:10 +0100
      Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper Peter Zijlstra <peterz@infradead.org> - 2017-02-07 09:10 +0100

csiph-web