Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575410

Re: [RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values of multiple controls in one go (at once) 2. Restructured the code for read/write of a single control

Show all headers | View raw

On Tue, 07 Feb 2017 05:33:05 +0100,
Takashi Sakamoto wrote:
> 
> On Feb 3 2017 16:24, Takashi Iwai wrote:
> > On Thu, 02 Feb 2017 04:45:48 +0100,
> > Takashi Sakamoto wrote:
> >>
> >> I'm _strongly_ interested in your two patches, because it has a
> >> potentiality to purge ASoC abuse of TLV feature, which was introduced
> >> in  2014 with a bad reviewing process.
> >
> > I don't think it can be a replacement for the extended TLV usages.
> > The proposed API is nothing but a loop of ctl elem read/write, and I'm
> > not sure whether it worth to introduce the new ioctls just for that.
> 
> In my opinion, an idea to handle several control elements in one system
> call could perhaps overcome current limitation of control elements,
> which comes from definition of 'struct snd_ctl_elem_value'. Aim of the
> abuse of TLV feature in ASoC part essentially comes from the
> limitation, as long as I understand.

Yes, it's the limitation, but it won't be eased by this kind of patch.
The TLV usage came just because of its required data size, sometimes
over mega bytes.  It's not about the number of elements.  It's about
the data size a single element needs to deal with.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values  of multiple  controls in one go (at once) 2. Restructured the code for  read/write of  a single control Satendra Singh Thakur <satendra.t@samsung.com> - 2017-02-03 06:30 +0100
  Re: [RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values of multiple  controls in one go (at once) 2. Restructured the code for read/write of  a single control Takashi Iwai <tiwai@suse.de> - 2017-02-03 08:30 +0100
    Re: [RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing  values of multiple controls in one go (at once) 2. Restructured the code for  read/write of a single control Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-07 05:40 +0100
      Re: [RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values of multiple controls in one go (at once) 2. Restructured the code for read/write of a single control Takashi Iwai <tiwai@suse.de> - 2017-02-07 07:30 +0100

csiph-web