Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
Date	Tue, 07 Feb 2017 06:50:01 +0100
Message-ID	<t86P7-71B-7@gated-at.bofh.it> (permalink)
References	<t72Nz-5vS-1@gated-at.bofh.it> <t7fhL-5Jz-5@gated-at.bofh.it> <t7fhL-5Jz-7@gated-at.bofh.it> <t7r9f-5oq-5@gated-at.bofh.it> <t7JSy-vs-5@gated-at.bofh.it> <t81FM-3Jw-7@gated-at.bofh.it> <t86P7-71B-9@gated-at.bofh.it>
X-Original-To	Jens Axboe <axboe@fb.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BBLROw4TZhlQ9lF4oQaIQVM77AFg6jWqaVwpUK1CLlQ=; b=xYPMS3f2ufHLmf4/vROPP33yf4ULfo32Kw/CvdecYmfsBUwWCmM0w5ed8dFYoUXpzf qTQOrxqBx5ugUDfoVC44HFEb5Qf1OhzEFV0lVW/m1DVUZ0EtS/YzY8guTNxtanPptgiF Du6XDfCZfJxj9SGDiCQbPcXr0Gk1txEHOqSb7CEC66uIZdqZ8i7pb/6hFb4DVn2sz465 I2NmEfLjURt7fRKhxFopBOvXR7t08DBErNbGiyhngFoIgPFv9JRlcOQ39FbClT0LKr8B ujVWuWZjswPjb22e9hj2/vERGIoJ5kKQXidKs7GQqgd/brCo+qYMLcr7L48i5devLS26 12Qg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BBLROw4TZhlQ9lF4oQaIQVM77AFg6jWqaVwpUK1CLlQ=; b=MeeRW4PI+LV9tIDBn1WudFPHG7CoXcNAMzErhwl4KV8DWak3gweuER1nw6/ia0eNUL G79U5AAhqdITcHp4LEStn2mbUHzdxc1hJtqxcA77E+9X1ZgzVNH81F4OdKRLorI5AFgQ yVSshCHAXvhdpUdur4ITTfiiWKcrOV4r3d5y+M6dCvbezFTvDzO026mfawsipS3sRyW6 /yRaPhLgjEhXV2zJQy1uLOEK3Lj56FN2TJTPjxWH3Tb/aje7+E5bLzQ/7j2vxe+oeoLR 3obuQB/hzIq3Qp3Fxz6CUHwC4BFPBBTsZMKblc+cOnIs4Unh+wY+ANMdeJ+yTimfUUnA wnew==
X-Gm-Message-State	AMke39mnkpyixtztztGrks2rXx7BN9hjOJGXreYhqcki9QLIwR10tYUADkXFg60PkVspMIKWZF/6xgKQ71sz1y++
X-Received	by 10.202.220.198 with SMTP id t189mr6968637oig.94.1486446133913; Mon, 06 Feb 2017 21:42:13 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	James Bottomley <James.Bottomley@hansenpartnership.com>, Christoph Hellwig <hch@lst.de>, kernel test robot <xiaolong.ye@intel.com>, Bart Van Assche <bart.vanassche@sandisk.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Jan Kara <jack@suse.cz>, Omar Sandoval <osandov@osandov.com>, Omar Sandoval <osandov@fb.com>, LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>, LKP <lkp@01.org>, linux-scsi <linux-scsi@vger.kernel.org>, linux-block@vger.kernel.org
X-Original-Date	Mon, 6 Feb 2017 21:42:13 -0800
X-Original-Message-ID	<CAPcyv4jkak-gX3gQaBJiEk1G79skdN2F9WL-sK2DjPwFhA8rdg@mail.gmail.com>
X-Original-References	<20170204070936.GE12121@yexl-desktop> <CAPcyv4j0syAsinM-KbeefKysJhM9zt6kvrX=0c2HrtPV_tRAHQ@mail.gmail.com> <CAPcyv4gBQDuj65KRmFvP2q4Qt3d3xycM8L_TypAzYkvhmUSh6A@mail.gmail.com> <20170205091314.GA3042@lst.de> <CAPcyv4gE0+3pZQV=V75wxddFVhWeAz1abfJ=q8D1Zi+8Oi17rA@mail.gmail.com> <1486426467.2474.122.camel@HansenPartnership.com> <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1575395

Show key headers only | View raw

On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe <axboe@fb.com> wrote:
> On 02/06/2017 05:14 PM, James Bottomley wrote:
>> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>>> Dan,
>>>>
>>>> can you please quote your emails?  I can't find any content
>>>> inbetween all these quotes.
>>>
>>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>>
>>> So with help from Xiaolong I was able to reproduce this, and it does
>>> not appear to be a regression. We simply change the failure output of
>>> an existing bug. Attached is a log of the same test on v4.10-rc7
>>> (i.e. without the recent block/scsi fixes), and it shows sda being
>>> registered twice.
>>>
>>> "[    6.647077] kobject (d5078ca4): tried to init an initialized
>>> object, something is seriously wrong."
>>>
>>> The change that "scsi, block: fix duplicate bdi name registration
>>> crashes" makes is to properly try to register sdb since the sda devt
>>> is still alive. However that's not a fix because we've managed to
>>> call blk_register_queue() twice on the same queue.
>>
>> OK, time to involve others: linux-scsi and linux-block cc'd and I've
>> inserted the log below.
>>
>> James
>>
>> ---
>>
>> [    5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
>> [    5.969672]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
>> [    5.971895] scsi 0:0:0:0: Direct-Access     Linux    scsi_debug       0186 PQ: 0 ANSI: 7
>> [    6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
>> [    6.026965] sd 0:0:0:0: [sda] Write Protect is off
>> [    6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
>> [    6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
>> [    6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
>> [    6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
>> [    6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
>> [    6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
>> [    6.546964] sd 0:0:0:0: [sda] Write Protect is off
>> [    6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
>> [    6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
>> [    6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
>
> So sda is probed twice, and hilarity ensues when we try to register it
> twice.  I can't reproduce this, using scsi_debug and with scsi_async
> enabled.
>
> This is running linux-next? What's your .config?
>

The original failure report is here:

http://marc.info/?l=linux-kernel&m=148619222300774&w=2

...but it reproduces on current mainline with the same config. I
haven't spotted what makes scsi_debug behave like this.

Thread

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup Dan Williams <dan.j.williams@intel.com> - 2017-02-04 21:40 +0100
  Re: [lkp-robot] [scsi, block] 0dba1314d4:  WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-04 22:10 +0100
    Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup Dan Williams <dan.j.williams@intel.com> - 2017-02-04 22:10 +0100
  Re: [lkp-robot] [scsi, block] 0dba1314d4:         WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup Christoph Hellwig <hch@lst.de> - 2017-02-05 10:20 +0100
    Re: [lkp-robot] [scsi, block] 0dba1314d4:  WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-07 01:20 +0100
      Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup Dan Williams <dan.j.williams@intel.com> - 2017-02-07 06:50 +0100
        Re: [lkp-robot] [scsi, block] 0dba1314d4:  WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-09 01:10 +0100
          Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup Dan Williams <dan.j.williams@intel.com> - 2017-02-10 04:30 +0100
      Re: [lkp-robot] [scsi, block] 0dba1314d4:  WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-11 17:10 +0100

csiph-web