Re: [PATCH 1/2] libceph: Remove unneeded stddef.h include

From	Stafford Horne <shorne@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] libceph: Remove unneeded stddef.h include
Date	2017-02-07 03:50 +0100
Message-ID	<t840V-54B-5@gated-at.bofh.it> (permalink)
References	<t7p7r-46L-1@gated-at.bofh.it> <t7p7r-46L-5@gated-at.bofh.it> <t7Ubg-7e3-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 06, 2017 at 04:16:55PM +0000, David Laight wrote:
> From: Stafford Horne
> > Sent: 05 February 2017 07:08
> > This was causing a build failure for openrisc when using musl and
> > gcc 5.4.0 since the file is not available in the toolchain.
> > 
> > It doesnt seem this is needed and removing it does not cause any build
> > warnings for me.
> 
> Hmmm... stddef.h is part of the SuS v2.
> Required to get definitions for NULL, offsetof(), ptrdiff_t and size_t.
> 
> So any system that is pretending to by unix-like ought to have one.

Hello,
I agree, and also I can see that musl and gcc both do provide it.  I am
not sure why its not getting included for kernel builds, I didnt look
into it much because on the other hand...

Linux also provides it in 'linux/stddef.h'.  In this case vchiq_shim.c
includes "vchiq_util.h".
  which includes "linux/string.h"
    which includes "linux/stddef.h"

So the requirement seems satisfied.

I am fine to send a patch to change the include to <linux/stddef.h> as I
mentioned in the cover letter.  But I dont think its really needed.

-Stafford

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Remove unneeded stddef.h includes Stafford Horne <shorne@gmail.com> - 2017-02-05 08:10 +0100
  [PATCH 2/2] staging: vchip_shim: Remove unneeded stddef.h include Stafford Horne <shorne@gmail.com> - 2017-02-05 08:10 +0100
  [PATCH 1/2] libceph: Remove unneeded stddef.h include Stafford Horne <shorne@gmail.com> - 2017-02-05 08:10 +0100
    Re: [PATCH 1/2] libceph: Remove unneeded stddef.h include Ilya Dryomov <idryomov@gmail.com> - 2017-02-06 11:20 +0100
    RE: [PATCH 1/2] libceph: Remove unneeded stddef.h include David Laight <David.Laight@ACULAB.COM> - 2017-02-06 17:20 +0100
      Re: [PATCH 1/2] libceph: Remove unneeded stddef.h include Stafford Horne <shorne@gmail.com> - 2017-02-07 03:50 +0100

csiph-web