Re: [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies
Date	2017-02-07 02:00 +0100
Message-ID	<t82it-3XP-1@gated-at.bofh.it> (permalink)
References	<t6U3D-7uQ-13@gated-at.bofh.it> <t6U3E-7uQ-25@gated-at.bofh.it> <t770R-8ii-13@gated-at.bofh.it> <t7cDf-3QH-1@gated-at.bofh.it> <t7xHJ-1ay-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 05, 2017 at 05:12:46PM +0100, Mark Brown wrote:
> On Sat, Feb 04, 2017 at 09:45:02AM -0800, Dmitry Torokhov wrote:
> > On Sat, Feb 04, 2017 at 12:48:19PM +0100, Mark Brown wrote:
> 
> > > It really shouldn't be either of these things, at least on DT systems.
> 
> > But it definitely happens on ACPI systems for drivers for peripherals
> > that we share between both x86 and ARM.
> 
> Something that makes the warning informational only on ACPI systems
> would be fine.

I can definitely select the severity based on acpi_disabled flag, but I
think you should reconsider: from what I have seen in the kernel quite a
few driversi, even OF-specific ones, select regulator_get_optional() for
no good reason other than to avoid this "scary" warning. If its severity
were reduced quite a few drivers could be switched to normal
regulator_get().

Candidates for conversion (not complete, just examples):

drivers/input/touchscreen/zforce_ts.c
drivers/input/touchscreen/tsc200x-core.c
drivers/power/avs/rockchip-io-domain.c
drivers/mfd/stmpe.c

... and more...

Thanks.

-- 
Dmitry

Thread

[PATCH 1/5] regulator: core: remove dead code in _regulator_get() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 23:00 +0100
  [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 23:00 +0100
    Re: [PATCH 5/5] regulator: core: lower severity level of message  about using dummy supplies Mark Brown <broonie@kernel.org> - 2017-02-04 12:50 +0100
      Re: [PATCH 5/5] regulator: core: lower severity level of message  about using dummy supplies Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-04 18:50 +0100
        Re: [PATCH 5/5] regulator: core: lower severity level of message  about using dummy supplies Mark Brown <broonie@kernel.org> - 2017-02-05 17:20 +0100
          Re: [PATCH 5/5] regulator: core: lower severity level of message  about using dummy supplies Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-07 02:00 +0100
            Re: [PATCH 5/5] regulator: core: lower severity level of message  about using dummy supplies Mark Brown <broonie@kernel.org> - 2017-02-08 19:20 +0100
  [PATCH 3/5] regulator: core: have _regulator_get() accept get_type argument Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-03 23:00 +0100
    Applied "regulator: core: have _regulator_get() accept get_type argument" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-02-04 11:50 +0100
  Applied "regulator: core: remove dead code in _regulator_get()" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-02-04 11:50 +0100

csiph-web