Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1575273
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine |
| Date | 2017-02-07 01:20 +0100 |
| Message-ID | <t81FM-3Jw-17@gated-at.bofh.it> (permalink) |
| References | <t81mq-3ns-9@gated-at.bofh.it> <t81mq-3ns-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Feb 06, 2017 at 03:55:20PM -0800, Florian Fainelli wrote:
> Calling phy_read_status() means that we may call into
> genphy_read_status() which in turn will use genphy_update_link() which
> can make changes to phydev->link outside of the state machine's state
> transitions. This is an invalid behavior that is now caught as of
> 811a919135b9 ("phy state machine: failsafe leave invalid RUNNING state")
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/4] net: Incorrect use of phy_read_status() Florian Fainelli <f.fainelli@gmail.com> - 2017-02-07 01:00 +0100
[PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine Florian Fainelli <f.fainelli@gmail.com> - 2017-02-07 01:00 +0100
Re: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine Andrew Lunn <andrew@lunn.ch> - 2017-02-07 01:20 +0100
RE: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine David Laight <David.Laight@ACULAB.COM> - 2017-02-07 12:50 +0100
Re: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine Andrew Lunn <andrew@lunn.ch> - 2017-02-07 14:20 +0100
[PATCH net-next 3/4] net: netcp: Do not clobber PHY link outside of state machine Florian Fainelli <f.fainelli@gmail.com> - 2017-02-07 01:00 +0100
[PATCH net-next 2/4] net: pxa168_eth: Do not clobber PHY link outside of state machine Florian Fainelli <f.fainelli@gmail.com> - 2017-02-07 01:00 +0100
[PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine Florian Fainelli <f.fainelli@gmail.com> - 2017-02-07 01:00 +0100
Re: [PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine Andrew Lunn <andrew@lunn.ch> - 2017-02-07 01:20 +0100
Re: [PATCH net-next 0/4] net: Incorrect use of phy_read_status() David Miller <davem@davemloft.net> - 2017-02-07 20:00 +0100
csiph-web