Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library

From	Mickaël Salaün <mic@digikod.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library
Date	2017-02-06 23:50 +0100
Message-ID	<t80gG-2FR-23@gated-at.bofh.it> (permalink)
References	(2 earlier) <t7Tyx-6JX-15@gated-at.bofh.it> <t7WZr-HE-11@gated-at.bofh.it> <t7WZs-HE-27@gated-at.bofh.it> <t7ZaX-214-37@gated-at.bofh.it> <t80gG-2FR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 06/02/2017 23:44, Daniel Borkmann wrote:
> On 02/06/2017 10:30 PM, Mickaël Salaün wrote:
>> On 06/02/2017 20:18, Daniel Borkmann wrote:
>>> On 02/06/2017 08:16 PM, Mickaël Salaün wrote:
>>>> On 06/02/2017 16:30, Daniel Borkmann wrote:
>>>>> On 02/06/2017 12:14 AM, Mickaël Salaün wrote:
>>>>>> Replace bpf_prog_load() with bpf_load_program() calls.
>>>>>>
>>>>>> Use the tools include directory instead of the installed one to allow
>>>>>> builds from other kernels.
>>>>>>
>>>>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>>>>> Cc: Alexei Starovoitov <ast@fb.com>
>>>>>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>>>>>> Cc: Shuah Khan <shuah@kernel.org>
>>>>>> ---
>>>>>>     tools/testing/selftests/bpf/Makefile        |  6 +++++-
>>>>>>     tools/testing/selftests/bpf/bpf_sys.h       | 21
>>>>>> ---------------------
>>>>>>     tools/testing/selftests/bpf/test_tag.c      |  6 ++++--
>>>>>>     tools/testing/selftests/bpf/test_verifier.c |  8 +++++---
>>>>>>     4 files changed, 14 insertions(+), 27 deletions(-)
>>>>>
>>>>> No objections, but if so, can't we add the remaining missing
>>>>> pieces to bpf lib, so we can remove bpf_sys.h altogether?
>>>>
>>>> OK, I'll send a new patch replacing bpf_sys.h entirely.
>>>
>>> Sounds great, thanks!
>>
>> Do you prefer a big patch or one for each replaced function?
> 
> I think it makes sense to split it into two: i) this patch as-is
> for the prog part, and ii) rest for maps.
> 

Hum, I already split them to ease the review. I'm going to send this
series now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library Mickaël Salaün <mic@digikod.net> - 2017-02-06 00:20 +0100
  Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from  the library Daniel Borkmann <daniel@iogearbox.net> - 2017-02-06 16:40 +0100
    Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the  library Mickaël Salaün <mic@digikod.net> - 2017-02-06 20:20 +0100
      Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from  the library Daniel Borkmann <daniel@iogearbox.net> - 2017-02-06 20:20 +0100
        Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the  library Mickaël Salaün <mic@digikod.net> - 2017-02-06 22:40 +0100
          Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from  the library Daniel Borkmann <daniel@iogearbox.net> - 2017-02-06 23:50 +0100
            Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the  library Mickaël Salaün <mic@digikod.net> - 2017-02-06 23:50 +0100

csiph-web