Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573930

[PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return error code -ENODEV from the of_find_compatible_node()
error handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: fix file module
---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
index a6c1176..f0fff21 100644
--- a/arch/arm/mach-hisi/platmcpm.c
+++ b/arch/arm/mach-hisi/platmcpm.c
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-05 17:40 +0100

csiph-web