Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573866

Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive

Show all headers | View raw

On Fri, Feb 3, 2017 at 6:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> In commit abeffce ("net/mlx5e: Fix a -Wmaybe-uninitialized warning"), I fixed a
> gcc warning for the ipv4 offload handling. Now we get the same warning for the
> added ipv6 support:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:815:40: warning: 'out_dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> We can apply the same workaround here as well.
>
> Fixes: ce99f6b97fcd ("net/mlx5e: Support SRIOV TC encapsulation offloads for IPv6 tunnels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

frustrating... I don't see the warning with gcc 5.3.1 [1], but still,
the patch is OKay

Acked-by: Or Gerlitz <ogerlitz@mellanox.com>

[1] I used #make KCFLAGS='-Wmaybe-uninitialized'
M=drivers/net/ethernet/mellanox/mlx5/core   -j something

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive Arnd Bergmann <arnd@arndb.de> - 2017-02-03 17:40 +0100
  Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive Or Gerlitz <gerlitz.or@gmail.com> - 2017-02-05 11:50 +0100
  Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized  false-positive David Miller <davem@davemloft.net> - 2017-02-06 22:40 +0100

csiph-web