Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573854

[PATCH] sched/fair: Fix the nohz.next_balance update mess

Show all headers | View raw

From: Wanpeng Li <wanpeng.li@hotmail.com>

The commit: 
  c5afb6a87f2 ("sched/fair: Fix nohz.next_balance update")

intends to update nohz.next_balance in two steps.

1) The ILB CPU utilizes next_balance variable in nohz_idle_balance() 
   to gather the shortest next balance of other idle CPUs before 
   updating nohz.next_balance. 
2) The ILB CPU updates the nohz.next_balance according to its own 
   next_balance after load balance on behalf of other idle CPUs.

However, there is a mess which breaks the original intention of the 
first step, every idle CPUs update nohz.next_balance during ILB CPU 
on behalf of them to do load balance, and then the ILB CPU utilizes 
next_balance variable in nohz_idle_balance() to gather the shortest 
next balance of other idle CPUs before updating nohz.next_balance.

This patch fixes it by don't update nohz.next_balance for other idle 
CPUs when ILB CPU on behalf of them to do load balance. 

Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
CC: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
 kernel/sched/fair.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 274c747..83948a4 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8750,7 +8750,8 @@ static void rebalance_domains(struct rq *rq, enum cpu_idle_type idle)
 		 * balance for itself and we need to update the
 		 * nohz.next_balance accordingly.
 		 */
-		if ((idle == CPU_IDLE) && time_after(nohz.next_balance, rq->next_balance))
+		if ((idle == CPU_IDLE) && time_after(nohz.next_balance, rq->next_balance) &&
+			!test_bit(NOHZ_BALANCE_KICK, nohz_flags(this_rq()->cpu)))
 			nohz.next_balance = rq->next_balance;
 #endif
 	}
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched/fair: Fix the nohz.next_balance update mess  Wanpeng Li <kernellwp@gmail.com> - 2017-02-05 11:10 +0100
  Re: [PATCH] sched/fair: Fix the nohz.next_balance update mess Vincent Guittot <vincent.guittot@linaro.org> - 2017-02-06 09:10 +0100
    Re: [PATCH] sched/fair: Fix the nohz.next_balance update mess Wanpeng Li <kernellwp@gmail.com> - 2017-02-06 09:40 +0100
      Re: [PATCH] sched/fair: Fix the nohz.next_balance update mess Vincent Guittot <vincent.guittot@linaro.org> - 2017-02-06 14:30 +0100
        Re: [PATCH] sched/fair: Fix the nohz.next_balance update mess Wanpeng Li <kernellwp@gmail.com> - 2017-02-06 23:10 +0100

csiph-web