Re: [PATCH] xen-netfront: Improve error handling during initialization

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen-netfront: Improve error handling during initialization
Date	2017-02-05 01:50 +0100
Message-ID	<t7jbH-8uq-3@gated-at.bofh.it> (permalink)
References	<t65ua-7Of-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Ross Lagerwall <ross.lagerwall@citrix.com>
Date: Wed, 1 Feb 2017 15:50:22 +0000

> * Delay timer creation so that if initializing a queue fails, the timer
> has not been setup yet.

setup_timer() doesn't do anything that must be "undone" if an error
occurs and we have to cleanup.

It just assigns some values to some timer struct fields, that's it.

Therefore this change is extraneous and unnecessary.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen-netfront: Improve error handling during initialization Ross Lagerwall <ross.lagerwall@citrix.com> - 2017-02-01 17:00 +0100
  Re: [PATCH] xen-netfront: Improve error handling during  initialization Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-01 20:00 +0100
    Re: [PATCH] xen-netfront: Improve error handling during  initialization Ross Lagerwall <ross.lagerwall@citrix.com> - 2017-02-02 16:00 +0100
      Re: [PATCH] xen-netfront: Improve error handling during  initialization Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-02 17:00 +0100
  Re: [PATCH] xen-netfront: Improve error handling during  initialization David Miller <davem@davemloft.net> - 2017-02-05 01:50 +0100

csiph-web