Re: [PATCH 4/5] Input: xpad - restore LED state after device resume

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] Input: xpad - restore LED state after device resume
Date	Sun, 05 Feb 2017 02:20:02 +0100
Message-ID	<t7jEJ-tr-3@gated-at.bofh.it> (permalink)
References	<t7j21-8qv-15@gated-at.bofh.it>
X-Original-To	Cameron Gutman <aicommander@gmail.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.33,336,1477983600"; d="gz'50?scan'50,208,50";a="1090955110"
MIME-Version	1.0
Content-Type	multipart/mixed; boundary="3V7upXqbjpZ4EhLz"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	568
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, dmitry.torokhov@gmail.com, rojtberg@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Cameron Gutman <aicommander@gmail.com>
X-Original-Date	Sun, 5 Feb 2017 09:17:14 +0800
X-Original-Message-ID	<201702050949.mTJDZN2o%fengguang.wu@intel.com>
X-Original-References	<20170205003002.28160-5-aicommander@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1573794

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Cameron,

[auto build test ERROR on input/next]
[also build test ERROR on v4.10-rc6 next-20170203]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Cameron-Gutman/Correctly-support-some-quirky-Xbox-One-pads/20170205-083659
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-x016-201706 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/input/joystick/xpad.c: In function 'xpad_resume':
>> drivers/input/joystick/xpad.c:1700:10: error: 'struct usb_xpad' has no member named 'led'
     if (xpad->led)
             ^~
>> drivers/input/joystick/xpad.c:1701:3: error: implicit declaration of function 'xpad_send_led_command' [-Werror=implicit-function-declaration]
      xpad_send_led_command(xpad, xpad->led->led_cdev.brightness);
      ^~~~~~~~~~~~~~~~~~~~~
   drivers/input/joystick/xpad.c:1701:35: error: 'struct usb_xpad' has no member named 'led'
      xpad_send_led_command(xpad, xpad->led->led_cdev.brightness);
                                      ^~
   cc1: some warnings being treated as errors

vim +1700 drivers/input/joystick/xpad.c

  1694				retval = xpad_start_xbox_one(xpad);
  1695			}
  1696			mutex_unlock(&input->mutex);
  1697		}
  1698	
  1699		/* LED state is lost across resume, so resend the last command */
> 1700		if (xpad->led)
> 1701			xpad_send_led_command(xpad, xpad->led->led_cdev.brightness);
  1702	
  1703		return retval;
  1704	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thread

[PATCH 0/5] Correctly support some quirky Xbox One pads Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100
  [PATCH 2/5] Input: xpad - add init packet for Hori and Titanfall 2 pads Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100
  [PATCH 5/5] Input: xpad - fix stuck mode button on Xbox One S pad Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100
    Re: [PATCH 5/5] Input: xpad - fix stuck mode button on Xbox One S pad Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-06 23:10 +0100
  [PATCH 4/5] Input: xpad - restore LED state after device resume Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100
    Re: [PATCH 4/5] Input: xpad - restore LED state after device resume kbuild test robot <lkp@intel.com> - 2017-02-05 02:20 +0100
      Re: [PATCH 4/5] Input: xpad - restore LED state after device resume Cameron Gutman <aicommander@gmail.com> - 2017-02-05 02:50 +0100
    Re: [PATCH 4/5] Input: xpad - restore LED state after device resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-06 23:10 +0100
      Re: [PATCH 4/5] Input: xpad - restore LED state after device resume Cameron Gutman <aicommander@gmail.com> - 2017-02-07 00:00 +0100
  [PATCH 3/5] Input: xpad - send rumble on Xbox One init to fix PowerA pads Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100
    Re: [PATCH 3/5] Input: xpad - send rumble on Xbox One init to fix  PowerA pads Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-06 23:20 +0100
  [PATCH 1/5] Input: xpad - use a packet array to start Xbox One pads Cameron Gutman <aicommander@gmail.com> - 2017-02-05 01:40 +0100

csiph-web