Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575144

Re: [PATCH] bug: Switch data corruption check to __must_check

Show all headers | View raw

On Mon, Feb 6, 2017 at 1:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Mon, Feb 6, 2017 at 9:45 PM, Kees Cook <keescook@chromium.org> wrote:
>> The CHECK_DATA_CORRUPTION() macro was designed to have callers do
>> something meaningful/protective on failure. However, using "return false"
>> in the macro too strictly limits the design patterns of callers. Instead,
>> let callers handle the logic test directly, but make sure that the result
>> IS checked by forcing __must_check (which appears to not be able to be
>> used directly on macro expressions).
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> The patch looks ok, but I have no memory of suggesting this. Was this an older
> conversation we had that I already forgot, or did you confuse me with someone
> else?

Old conversation that we had. :)

https://patchwork.kernel.org/patch/9286627/

It just took me *cough* 6 months ... :P

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bug: Switch data corruption check to __must_check Kees Cook <keescook@chromium.org> - 2017-02-06 21:50 +0100
  Re: [PATCH] bug: Switch data corruption check to __must_check Arnd Bergmann <arnd@arndb.de> - 2017-02-06 22:10 +0100
    Re: [PATCH] bug: Switch data corruption check to __must_check Kees Cook <keescook@chromium.org> - 2017-02-06 22:20 +0100
  Re: [PATCH] bug: Switch data corruption check to __must_check "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-02-07 21:50 +0100
    Re: [PATCH] bug: Switch data corruption check to __must_check Kees Cook <keescook@chromium.org> - 2017-02-07 22:00 +0100
      Re: [PATCH] bug: Switch data corruption check to __must_check "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-02-07 22:40 +0100

csiph-web