Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575090

Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device

Show all headers | View raw

On Mon, Feb 06, 2017 at 11:15:33AM -0800, Tadeusz Struk wrote:
> Some hardware has multiple HFIs within the same ASIC, each one on a
> sepatate bus number. In some devices the numbers labeled on the
> faceplate of the device don't match the PCI bus order, and the result
> is that the devices (ports) are probed in the opposite order of their
> port numbers. The result is IB device unit numbers are in reverse order
> from the faceplate numbering. This leads to confusion, and errors.
> Use EPROBE_DEFER error code to enforce correct port order.
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
>  drivers/infiniband/hw/hfi1/chip.c |   95 ++++++++++++++++++++++++++++++++++++-
>  drivers/infiniband/hw/hfi1/chip.h |    2 -
>  drivers/infiniband/hw/hfi1/init.c |    1 
>  3 files changed, 94 insertions(+), 4 deletions(-)

Still no on this from me, this is a horrible abuse of the device core.

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport  device Tadeusz Struk <tadeusz.struk@intel.com> - 2017-02-06 20:20 +0100
  Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport  device Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-02-06 20:30 +0100
    Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport  device Christoph Hellwig <hch@infradead.org> - 2017-02-06 22:10 +0100
      Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport  device Greg KH <gregkh@linuxfoundation.org> - 2017-02-07 10:20 +0100

csiph-web