Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574978

RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

Show all headers | View raw

>-----Original Message-----
>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>Behalf Of Arnd Bergmann
>Sent: Monday, February 06, 2017 6:27 PM
>To: Jiri Pirko <jiri@mellanox.com>; Ido Schimmel <idosch@mellanox.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>;
>Vadim Pasternak <vadimp@mellanox.com>; Elad Raz <eladr@mellanox.com>; Ivan
>Vecera <cera@cera.cz>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
>
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Yotam Gigi <yotamg@mellanox.com>

>---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>index 76a7574c3c7d..ef23eaedc2ff 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
> config MLXSW_SPECTRUM
> 	tristate "Mellanox Technologies Spectrum support"
> 	depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV &&
>VLAN_8021Q
>+	depends on PSAMPLE || PSAMPLE=n
> 	select PARMAN
> 	default m
> 	---help---
>--
>2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [net-next] mlxsw: add psample dependency for spectrum Arnd Bergmann <arnd@arndb.de> - 2017-02-06 17:30 +0100
  RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum Yotam Gigi <yotamg@mellanox.com> - 2017-02-06 17:50 +0100
  Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum Jiri Pirko <jiri@resnulli.us> - 2017-02-07 10:50 +0100
  Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum David Miller <davem@davemloft.net> - 2017-02-07 17:50 +0100

csiph-web