Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574924

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

Show all headers | View raw

On Mon, 6 Feb 2017, Richard Leitner wrote:

> On 02/06/2017 04:12 PM, Alan Stern wrote:
> > On Mon, 6 Feb 2017, Richard Leitner wrote:
> > 
> >> For USB string descriptors we need to convert ASCII strings to UTF16-LE.
> >> Therefore make a simple helper function (based on ascii2desc from
> >> drivers/usb/core/hcd.c) for that purpose.
> > 
> > You know, we already have utf8s_to_utf16s() in fs/nls/nls_base.c.  
> > Maybe it doesn't do exactly what you want, but it should be pretty 
> > close.  Adding another helper function to do essentially the same thing 
> > seems unnecessary.
> 
> Thanks for that pointer. I totally agree with you.
> 
> So it would be OK to include linux/nls.h and use utf8s_to_utf16s() in
> drivers/usb/{core/hcd.c,misc/usb251xb.c}?

Well, we already include linux/nls.h in drivers/usb/core/message.c and
a few files under drivers/usb/gadget.  Putting it in a few more places
shouldn't hurt.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Richard Leitner <richard.leitner@skidata.com> - 2017-02-06 15:10 +0100
  Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Alan Stern <stern@rowland.harvard.edu> - 2017-02-06 16:20 +0100
    Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Richard Leitner <richard.leitner@skidata.com> - 2017-02-06 16:40 +0100
      Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Alan Stern <stern@rowland.harvard.edu> - 2017-02-06 16:50 +0100
        Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Richard Leitner <richard.leitner@skidata.com> - 2017-02-06 16:50 +0100
  Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-06 17:50 +0100
    Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper Richard Leitner <richard.leitner@skidata.com> - 2017-02-08 10:00 +0100

csiph-web