Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1574865

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size>

From Matthew Wilcox <willy@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size>
Date 2017-02-06 16:00 +0100
Message-ID <t7SVP-6g8-9@gated-at.bofh.it> (permalink)
References <t6QCK-5b2-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Feb 03, 2017 at 07:10:08PM +0100, Vlastimil Babka wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index a95fd4fed0a8..ede31b59bb9f 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1293,7 +1293,8 @@ void __init kmem_cache_init(void)
>  	 * Initialize the caches that provide memory for the  kmem_cache_node
>  	 * structures first.  Without this, further allocations will bug.
>  	 */
> -	kmalloc_caches[INDEX_NODE] = create_kmalloc_cache("kmalloc-node",
> +	kmalloc_caches[INDEX_NODE] = create_kmalloc_cache(
> +				get_kmalloc_cache_name(INDEX_NODE),

Could we lose the 'get_' from the front?  I think 'kmalloc_cache_name()' is
just as informative.

Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Vlastimil Babka <vbabka@suse.cz> - 2017-02-03 19:20 +0100
  Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> kbuild test robot <lkp@intel.com> - 2017-02-04 03:30 +0100
    Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Vlastimil Babka <vbabka@suse.cz> - 2017-02-04 09:30 +0100
  Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Christoph Lameter <cl@linux.com> - 2017-02-06 15:50 +0100
  Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Matthew Wilcox <willy@infradead.org> - 2017-02-06 16:00 +0100
    Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Christoph Lameter <cl@linux.com> - 2017-02-06 16:00 +0100
  Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Andrew Morton <akpm@linux-foundation.org> - 2017-02-07 22:50 +0100
    Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Vlastimil Babka <vbabka@suse.cz> - 2017-02-08 10:20 +0100
      Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Vlastimil Babka <vbabka@suse.cz> - 2017-02-08 10:50 +0100
      Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Christoph Lameter <cl@linux.com> - 2017-02-08 16:30 +0100
      Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Andrew Morton <akpm@linux-foundation.org> - 2017-02-08 23:00 +0100
        Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size> Vlastimil Babka <vbabka@suse.cz> - 2017-02-09 10:40 +0100

csiph-web